Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't print AttributeValues in EncryptionContext.toString() #100

Open
johnwalker opened this issue Oct 3, 2019 · 0 comments
Open

Don't print AttributeValues in EncryptionContext.toString() #100

johnwalker opened this issue Oct 3, 2019 · 0 comments

Comments

@johnwalker
Copy link
Contributor

johnwalker commented Oct 3, 2019

https://github.com/aws/aws-dynamodb-encryption-java/blob/master/sdk1/src/main/java/com/amazonaws/services/dynamodbv2/datamodeling/encryption/EncryptionContext.java#L220

https://github.com/aws/aws-dynamodb-encryption-java/blob/master/sdk2/src/main/java/software/amazon/cryptools/dynamodbencryptionclientsdk2/encryption/EncryptionContext.java#L182

A safe toString() method for EncryptionContext would be extremely useful for logging within material providers, and we can get there by excluding attributeValues from being printed. Since it is likely that tests rely on this today, we should consider doing this with a minor bump. (Note: We haven't published the sdk2 version yet, so it's not necessary to do a bump there.)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant