Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[RFC] EnvVarProcessor using AWS Secrets Manager #50

Open
patrick-mcdougle opened this issue Oct 17, 2018 · 7 comments
Open

[RFC] EnvVarProcessor using AWS Secrets Manager #50

patrick-mcdougle opened this issue Oct 17, 2018 · 7 comments
Labels
needs-discussion p3 This is a minor priority issue

Comments

@patrick-mcdougle
Copy link

Would anyone use a EnvVarProcessor that uses the AWS Secrets Manager?

What I'm thinking is to implement EnvVarProcessorInterface and create a awsSecret key that takes a SecretId, and optionally a versionID and / or versionStage and resolves this in runtime. Then in config, you can use a string similar to this to use amazon secrets in the config.

parameters:
    db_dsn: "mysql://db_user:%env(awsSecret:db_password)%@127.0.0.1:3306/db_name"

Thoughts? Does anyone want this? Would such a feature be merged?

@patrick-mcdougle
Copy link
Author

Small proof of concept that's untested. Theoretically if your AWS bundle is configured correctly (and you grant secrets manager access), this will work.

https://github.com/patrick-mcdougle/aws-sdk-php-symfony/tree/pmcd-env-processor-secrets

@sleavitt
Copy link

sleavitt commented Nov 9, 2018

Perhaps this as a basis is worth a look - https://github.com/incompass/aws-secrets-bundle

@patrick-mcdougle
Copy link
Author

@sleavitt Amazing. I'm seeing double! I think we can probably close this RFC. Anyone who needs this can use the bundle that you've linked to above.

@rimvislt
Copy link

rimvislt commented Mar 4, 2021

I am looking to implement aws secret manager for symfony variables, that bundle which is suggested above does not look supported, development is not moving forward inside it so will be good to have something under aws otherwise it is no other option just implement myself it.

@rimvislt
Copy link

rimvislt commented Mar 4, 2021

Can we reopen this RFC ?

@patrick-mcdougle
Copy link
Author

We can try 😀

@vkhramtsov
Copy link

Any news here?

@bhavya2109sharma bhavya2109sharma added the p3 This is a minor priority issue label Jul 31, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs-discussion p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

6 participants