Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create a ktlint rule to standardize import #973

Closed
zhangzhx opened this issue May 17, 2019 · 3 comments
Closed

Create a ktlint rule to standardize import #973

zhangzhx opened this issue May 17, 2019 · 3 comments
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@zhangzhx
Copy link
Contributor

Some of the rules we need to consider:

  • Do we want import as?
  • import some.package.* is not allowed
@rli
Copy link
Contributor

rli commented May 17, 2019

ktlint has editorconfig support, maybe we just need to set that up.
ktlint, intellij plugin

couple of things i've noticed; there might be more:

  • long code lines: when do we break?
  • import ordering
  • 4 vs 8 spaces for "Continuation indent"

@abrooksv
Copy link
Contributor

We also need to migrate our ktlint rules to new package pattern and migrate to https://github.com/pinterest/ktlint

@abrooksv abrooksv added the feature-request New feature or enhancement. May require GitHub community feedback. label May 17, 2019
@abrooksv
Copy link
Contributor

abrooksv commented May 23, 2019

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

3 participants