Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: unnecessary strict node requirement in engines in package.json #2498

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: unnecessary strict node requirement in engines in package.json #2498

merged 1 commit into from
Oct 11, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 11, 2024

Fixes #1329

We already use jsii to manage Node.js versions. No need to overzealously enforce via engines.

@mergify mergify bot merged commit e9bf09c into 10.x Oct 11, 2024
13 checks passed
@mergify mergify bot deleted the mrgrain/fix/no-engines-version branch October 11, 2024 17:25
@peterboni peterboni mentioned this pull request Nov 2, 2024
Open
@grommir grommir mentioned this pull request Nov 2, 2024
Merged
@gabrieltorreswm gabrieltorreswm mentioned this pull request Nov 3, 2024
Open
@Abisdebra Abisdebra mentioned this pull request Nov 4, 2024
Open
@jsamuel1 jsamuel1 mentioned this pull request Nov 5, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request Nov 5, 2024
Open
@atulgoel126 atulgoel126 mentioned this pull request Nov 7, 2024
Closed
@gentksb gentksb mentioned this pull request Nov 7, 2024
Merged
@ithunter0428 ithunter0428 mentioned this pull request Nov 8, 2024
Open
@bensullivan2002 bensullivan2002 mentioned this pull request Nov 9, 2024
Open
@antonio-marasescu antonio-marasescu mentioned this pull request Nov 10, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surprisingly strict node requirement in engines in package.json
2 participants
@mrgrain @kaizencc