Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Add latest instance types that support EFA #1151

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

bryantbiggs
Copy link
Member

Issue

  • N/A

Description of changes

  • Add latest instance types that support EFA

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

version: v0.5.4
appVersion: "v0.5.4"
version: v0.5.5
appVersion: "v0.5.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appVersion should stay at "v0.5.4" which is the latest image version ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's keep appVersion same as the efa-plugin version so that we can keep a track

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes - makes sense. corrected in 7f82abe

@bryantbiggs bryantbiggs force-pushed the chore/efa-instance-types branch from bf48670 to 7f82abe Compare September 21, 2024 01:32
@bryantbiggs bryantbiggs requested a review from dims as a code owner September 21, 2024 01:32
Copy link
Collaborator

@jaydeokar jaydeokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bryantbiggs bryantbiggs merged commit cf23219 into aws:master Sep 21, 2024
1 check passed
@bryantbiggs bryantbiggs deleted the chore/efa-instance-types branch October 9, 2024 15:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants