Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add extraOutputs support for kinesis_streams plugin ConfigMap #1193

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

moshiaiz
Copy link
Contributor

@moshiaiz moshiaiz commented Feb 4, 2025

Description of changes

  • Added support for extraOutputs in the kinesis_streams plugin output within the ConfigMap template.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

I deployed the chart with the following config overrides for kinesis_streams:

kinesis_streams:
  enabled: true
  match: "*"
  region: eu-west-1
  stream: my-kinesis-stream
  extraOutputs: |
    Retry_Limit     False
  • This correctly appended "Retry_Limit False" to the [OUTPUT] section in the generated ConfigMap.
  • I verified that Fluent Bit recognized the new setting and that unlimited retries worked as expected.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@moshiaiz moshiaiz requested a review from dims as a code owner February 4, 2025 12:22
@moshiaiz moshiaiz force-pushed the add-extra-outputs-kinesis-streams branch from 682ee18 to 13d0ec8 Compare February 4, 2025 12:27
@dims
Copy link
Member

dims commented Feb 4, 2025

cc @bryantbiggs

Copy link

@arditti arditti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are aligned as it done for other services as well, like: firehose.extraOutputs, kinesis.extraOutputs and elasticsearch.extraOutputs

LGTM

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantbiggs bryantbiggs merged commit 3eb7a62 into aws:master Feb 4, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants