Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(aws-quicksight): quicksight generated Python is really huge could it be smaller? #4066

Open
2 tasks
jeffb4 opened this issue Apr 21, 2023 · 5 comments
Open
2 tasks
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1

Comments

@jeffb4
Copy link

jeffb4 commented Apr 21, 2023

Describe the feature

This isn't a bug, but the size of the quicksight Python code is very large and breaks in vscode's default python server

[Error - 10:24:44 PM] (36155) File length of "/home/vscode/.local/lib/python3.8/site-packages/aws_cdk/aws_quicksight/__init__.py" is 72024295 which exceeds the maximum supported file size of 52428800

I confirmed that yeah, that's a beefy boi

-rw-rw-r-- 1 vscode vscode 69M Apr 20 23:08 /home/vscode/.local/lib/python3.8/site-packages/aws_cdk/aws_quicksight/__init__.py

Use Case

I don't think the python language server would be able to by default show typing hints etc for that module, which would be great.

Proposed Solution

I understand the Python is generated with jsii from typescript sources - I don't know if the typescript source file is huge and could be shrunk down, or if the conversion is particularly inefficient.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

aws-cdk-lib 2.73.0

Environment details (OS name and version, etc.)

Linux docker-desktop 5.15.49-linuxkit aws/aws-cdk#1 SMP Tue Sep 13 07:51:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

@jeffb4 jeffb4 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2023
@peterwoodworth peterwoodworth added p1 effort/large Large work item – several weeks of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 21, 2023
@peterwoodworth
Copy link
Contributor

Thanks for reporting this @jeffb4,

This is going to be related to jsii, I'm going to transfer this issue to that repository, let's see what they say 🙂

@mrgrain
Copy link
Contributor

mrgrain commented Jun 12, 2023

This service has a very large TypeScript definition and we wouldn't really be able to reduce its size without removing functionality. Saying that, the jsii package is aggravating this issue to a much larger problem than it is in TS.

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 14, 2023

I see it already. This file is ginormous because of the automatically generated code examples. The example for CfnAnalysis spans 30k lines (!).

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 14, 2023

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 16, 2023

Not sure this is going to help enough. The file is 900k lines, and the big examples are only 30k lines.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

4 participants