HTTP/1: Support streaming requests of unknown length (#714)

graebm · web-flow · commit 0a27f7412660 · 2025-03-17T09:23:39.000-07:00
**Issue:** aws-sdk-cpp needs to send streaming requests of unknown content length. This isn't currently supported in our HTTP/1 client. **Description of changes:** - Update submodules: aws-c-auth v0.8.5 -> v0.8.6 aws-c-cal v0.8.3 -> v0.8.7 aws-c-common v0.11.1 -> v0.12.0 aws-c-event-stream v0.5.2 -> v0.5.4 aws-c-http v0.9.3 -> v0.9.5 aws-c-io v0.16.0 -> v0.17.0 aws-c-s3 v0.7.11 -> v0.7.13 aws-lc v1.46.1 -> v1.48.4 s2n v1.5.13 -> v1.5.14 - Bring in change that allows HTTP/1 streams of unknown length: - awslabs/aws-c-http#506 - Remove hack in Base64 decoded logic, which is no longer necessary due to this change: - awslabs/aws-c-common#1188
diff --git a/crt/aws-c-auth b/crt/aws-c-auth
@@ -1 +1 @@
-Subproject commit 2d85beff96bee7ee4734c21c7fc6b15e9d07b85e
+Subproject commit 01dd06acd2b8865a4a6bc232380ee69a042af47d
diff --git a/crt/aws-c-cal b/crt/aws-c-cal
@@ -1 +1 @@
-Subproject commit 7299c6ab9244595b140d604475cdd6c6921be8ae
+Subproject commit d59c198db17c42a48e3ee105d12357f5a9efecf3
diff --git a/crt/aws-c-common b/crt/aws-c-common
@@ -1 +1 @@
-Subproject commit 6401c830ffcd82ee9c9e26255f2fadf7092c7321
+Subproject commit 7fb0071ab88182bffcc18a4a09bdb4dd2a5751d8
diff --git a/crt/aws-c-event-stream b/crt/aws-c-event-stream
@@ -1 +1 @@
-Subproject commit 4bd476bd0c629e8fab4ec0ace92830efc6a79e6c
+Subproject commit 9312b052583183b98526aaeb91e5c72ec3db9627
diff --git a/crt/aws-c-http b/crt/aws-c-http
@@ -1 +1 @@
-Subproject commit 590c7b597f87e5edc080b8b77418690c30319832
+Subproject commit e3a9cabc664630120df25c28ec710199b8e8b15b
diff --git a/crt/aws-c-io b/crt/aws-c-io
@@ -1 +1 @@
-Subproject commit 5fcecfc621059e254f2dc0dcac46265fcba0bf3a
+Subproject commit 318f7e57e7871e5b0d48a281cc5dcb7f79ccecdd
diff --git a/crt/aws-c-s3 b/crt/aws-c-s3
@@ -1 +1 @@
-Subproject commit 6eb8be530b100fed5c6d24ca48a57ee2e6098fbf
+Subproject commit 169842b7e2f81d71d0719d4a77f9c3e186512f99
diff --git a/crt/aws-lc b/crt/aws-lc
@@ -1 +1 @@
-Subproject commit becf5785c131012bb5a64f3da6cdb117ddc0f431
+Subproject commit d3e6957b9db2d9c587e77396d7b428139047ec31
diff --git a/crt/s2n b/crt/s2n
@@ -1 +1 @@
-Subproject commit 21cefc1091b3953ef543c9e72b932b6431fadc6e
+Subproject commit 4ed4f1a658b70559ec4a18e91d1319daa14b0610
diff --git a/source/Types.cpp b/source/Types.cpp
@@ -110,12 +110,8 @@ namespace Aws
                 return {};
             }
 
-            // encoding appends a null terminator, and accounts for it in the encoded length,
-            // which makes the string 1 character too long
-            if (outputStr.back() == 0)
-            {
-                outputStr.pop_back();
-            }
+            AWS_ASSERT(outputStr.length() == tempBuf.len);
+
             return outputStr;
         }
     } // namespace Crt

Original file line number	Diff line number	Diff line change
`@@ -110,12 +110,8 @@ namespace Aws`
`110`	`110`	`return {};`
`111`	`111`	`}`
`112`	`112`
`113`		`- // encoding appends a null terminator, and accounts for it in the encoded length,`
`114`		`- // which makes the string 1 character too long`
`115`		`- if (outputStr.back() == 0)`
`116`		`- {`
`117`		`- outputStr.pop_back();`
`118`		`- }`
	`113`	`+ AWS_ASSERT(outputStr.length() == tempBuf.len);`
	`114`	`+`
`119`	`115`	`return outputStr;`
`120`	`116`	`}`
`121`	`117`	`} // namespace Crt`