Skip to content

improv: logger autocomplete for PyCharm #110

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

heitorlessa
Copy link
Contributor

Issue #, if available: #107

Description of changes:

Problem summary: PyCharm does not infer from proxied objects when building autocomplete. This means #99 broke autocomplete feature in PyCharm but not in VSCode.

This PR re-adds sub-classing for Logger, and an additional test to cover log statement location key.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2020

Codecov Report

Merging #110 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          499       499           
  Branches        46        46           
=========================================
  Hits           499       499           
Impacted Files Coverage Δ
aws_lambda_powertools/logging/logger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32549c8...75b2c16. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 16, 2020

This pull request introduces 1 alert when merging 1eafdf4 into 32549c8 - view on LGTM.com

new alerts:

  • 1 for Missing call to __init__ during object initialization

We don't initialize logging.Logger as we use an inner Logger and obj proxy instead.
@lgtm-com
Copy link

lgtm-com bot commented Aug 16, 2020

This pull request introduces 1 alert when merging 75b2c16 into 32549c8 - view on LGTM.com

new alerts:

  • 1 for Missing call to __init__ during object initialization

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants