Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Add single dash arguments support to sendmail command #123

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

richieri
Copy link
Contributor

@richieri richieri commented Jun 6, 2023

mailpit sendmail -t was not working because of the single dash argument
parsing. This commit fixes it.

mailpit sendmail -t was not working because of the single dash argument
parsing. This commit fixes it.
@richieri
Copy link
Contributor Author

richieri commented Jun 6, 2023

Hi, I was trying to use mailpit sendmail for testing with a ticket management software which uses sendmail and has -t argument fixed, with a single dash. When running mailpit sendmail -t, I was receiving the error 'Error: unknown shorthand flag: 't' in -t'. This branch/commit fixed that for me.

@axllent axllent changed the title Add single dash arguments support to sendmail command Fix: Add single dash arguments support to sendmail command Jun 6, 2023
@axllent
Copy link
Owner

axllent commented Jun 6, 2023

Sorry about this - I was working on getting -bs as a working flag option, however pflags doesn't support words using a single dash, so I rewrote that part and tried to simplify it. I failed... thank you, I will merge and release a new version shortly.

@axllent axllent marked this pull request as ready for review June 6, 2023 19:33
@axllent axllent merged commit a2ab350 into axllent:develop Jun 6, 2023
@richieri
Copy link
Contributor Author

richieri commented Jun 6, 2023

Thanks!

@axllent
Copy link
Owner

axllent commented Jun 6, 2023

No problem, and thank you for the MR and bringing the issue to my attention!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants