when drop spine extension, build error

[blairwang]

in file cocostudio/SpineSkeletonDataCache.h, it includes spine.h

axmol/extensions/cocostudio/src/cocostudio/SpineSkeletonDataCache.h:4:10: fatal error: 'spine/spine.h' file not found
4 | #include "spine/spine.h"

need add micro to avoid this error

[paulocoutinhox]

Did you use these runtimes?
https://github.com/axmolengine/spine-axmol

[blairwang]

Did you use these runtimes? https://github.com/axmolengine/spine-axmol

Sorry, I didn't use spine in my game.

I just try to build wasm version to see how small the wasm file can be, If I can complete the build, I guess it can be less than 10 MB in demo project, that will be very cool.

[paulocoutinhox]

Hi @blairwang,

So, set in your CMakeLists.txt:

set(AX_ENABLE_EXT_SPINE OFF CACHE BOOL "the spine extension" FORCE)

[rh101]

@blairwang If you have time, please try the changes in PR #2346 to see if it fixes the issue for you.

@paulocoutinhox The problem isn't about setting the cmake option, but that the source code still referencing Spine even when Spine is disabled.

[paulocoutinhox]

Hi,

But if you disable the Spine Extension, the file still included in files to be compile?

I don't understand why extensions/cocostudio/src/cocostudio/SpineSkeletonDataCache.h is compiled if Spine is disabled and need add code to ignore the file content https://github.com/rh101/axmol/blob/41a33a70a74e18727a002c11888681fc48a327dc/extensions/cocostudio/src/cocostudio/SpineSkeletonDataCache.h

Is because Spine only disable the runtime and not the spine files inside cocostudio?

Thanks.

[blairwang]

Hi,

But if you disable the Spine Extension, the file still included in files to be compile?

I don't understand why extensions/cocostudio/src/cocostudio/SpineSkeletonDataCache.h is compiled if Spine is disabled and need add code to ignore the file content https://github.com/rh101/axmol/blob/41a33a70a74e18727a002c11888681fc48a327dc/extensions/cocostudio/src/cocostudio/SpineSkeletonDataCache.h

Is because Spine only disable the runtime and not the spine files inside cocostudio?

Thanks.

Yes, I think it should be fixed...

[blairwang]

My first time submit a pr...

#2347

tested ok by myself

[rh101]

But if you disable the Spine Extension, the file still included in files to be compile?

I don't understand why extensions/cocostudio/src/cocostudio/SpineSkeletonDataCache.h is compiled if Spine is disabled and need add code to ignore the file content https://github.com/rh101/axmol/blob/41a33a70a74e18727a002c11888681fc48a327dc/extensions/cocostudio/src/cocostudio/SpineSkeletonDataCache.h

Those files are referenced in a lot of places, so a more complete fix would would need to address that, which @blairwang seems to have done in PR #2347.