add checkbox for extensive LogCat messages (in SettingsActivity)

Author: steppenhahn

res/layout/activity_settings.xml

@@ -101,6 +101,31 @@
 	         android:text="@string/settings_text_defaultnotetitle_datetime"
 	         />
 
+	     <!-- horizontal line -->
+
+	     <View
+	         android:id="@+id/grey_line"
+	         android:layout_width="match_parent"
+	         android:layout_height="1dp"
+	         android:background="#aaaaaa"
+	         android:layout_marginTop="30dp" />
+	     
+	     <!-- Extensive logcat -->
+	     <TextView
+	        android:layout_width="wrap_content"
+	        android:layout_height="wrap_content"
+	        android:text="@string/settings_text_debug" 
+	        android:textSize="17sp"
+	        android:layout_marginTop="3dp"
+	        />
+	     <CheckBox 
+	         android:id="@+id/checkbox_extensive_log"
+	         android:checked="false"
+	         android:layout_width="wrap_content"
+	         android:layout_height="wrap_content"
+	         android:text="@string/settings_text_extensive_log_output"
+	         />
+	     
 
 
 	</LinearLayout>

res/values/strings.xml

@@ -55,6 +55,9 @@
     <string name="settings_text_defaultnotetitle">Default Note Title</string>
     <string name="settings_text_defaultnotetitle_datetime">Date and time</string>
     <string name="settings_text_saved">Settings saved</string>
+    <string name="settings_text_debug">Debug</string>
+    <string name="settings_text_extensive_log_output">Enable extensive LogCat output</string>
+    
     <!-- Toasts -->
     <string name="toast_enter_valid_username">Please enter your ownCloud-server username</string>
     <string name="toast_enter_password">Please enter your ownCloud-server password</string>

src/org/aykit/owncloud_notes/NoteListActivity.java

@@ -64,11 +64,12 @@ public class NoteListActivity
 	private final String apiPath = "/index.php/apps/notes/api/v0.2/notes";
 
 	/**
-	 * use this variable to turn extensive logcat messages on or off. 
+	 * used to turn extensive logcat messages on or off. 
 	 * debugOn == true -> show more log messages
 	 * debugOn == false -> show only essential messages
+	 * edited in SettingsActivity
 	 */
-	private final boolean debugOn = false;
+	private boolean debugOn;
 
 
 	@Override
@@ -77,12 +78,15 @@ protected void onCreate(Bundle savedInstanceState) {
 		setContentView(R.layout.activity_note_list);
 
 		updateSettings();
+		debugOn = settings.getBoolean(SettingsActivity.PREF_EXTENSIVE_LOG, false); 
+		
 		SharedPreferences.Editor editor = settings.edit();
 		editor.putBoolean(SettingsActivity.PREF_MENU_INFLATED, false); //this is done to save the fact that menus are not inflated yet.
 		editor.commit();
 
 		loaderManager = getLoaderManager();
 		notesOpenHelper = new NotesOpenHelper(this);
+		
 	}
 
 	@Override
@@ -971,10 +975,7 @@ protected String doInBackground(String... anUrl) {
 
 				String auth = settings.getString(SettingsActivity.PREF_USERNAME, "username") + ":" + settings.getString(SettingsActivity.PREF_PASSWOORD, "password");
 
-				if(debugOn)
-				{
-					Log.d("DOWNLOADTASK", "auth=" + auth);
-				}
+				//Log.d("DOWNLOADTASK", "auth=" + auth);
 
 				String basicAuth = "Basic " + new String(Base64.encode(auth.getBytes(), Base64.DEFAULT));
 				urlConnection.setRequestProperty("Authorization", basicAuth);

src/org/aykit/owncloud_notes/SettingsActivity.java

@@ -26,6 +26,7 @@ public class SettingsActivity extends Activity {
 	public static final String PREF_DEFAULT_TITLE = "defaultTitle";
 	public static final String PREF_INITIALIZED = "initialized";
 	public static final String PREF_MENU_INFLATED = "menuInflated";
+	public static final String PREF_EXTENSIVE_LOG = "extensiveLog";
 
 	private final int minimumPasswordLength = 1;
 	private final char[] forbiddenSymbols = { '"', '\'' };
@@ -35,6 +36,7 @@ public class SettingsActivity extends Activity {
 	private EditText address;
 	private CheckBox autoSync;
 	private CheckBox defaultTitle;
+	private CheckBox extensiveLogCat;
 	private SharedPreferences settings;
 
 	@Override
@@ -53,7 +55,7 @@ protected void onCreate(Bundle savedInstanceState) {
 		address = (EditText) findViewById(R.id.edittext_server_address);
 		autoSync = (CheckBox) findViewById(R.id.checkbox_sync_automatically);
 		defaultTitle = (CheckBox) findViewById(R.id.checkbox_defaultnotetitle);
-		
+		extensiveLogCat = (CheckBox) findViewById(R.id.checkbox_extensive_log);
 
 		settings = PreferenceManager.getDefaultSharedPreferences(this);
 
@@ -62,8 +64,7 @@ protected void onCreate(Bundle savedInstanceState) {
 		address.setText(settings.getString(PREF_ADDRESS, ""));
 		autoSync.setChecked(settings.getBoolean(PREF_AUTOSYNC, true));
 		defaultTitle.setChecked( settings.getBoolean(PREF_DEFAULT_TITLE, true));
-		
-		
+		extensiveLogCat.setChecked(settings.getBoolean(PREF_EXTENSIVE_LOG, false));
 	}
 
 	@Override
@@ -149,6 +150,7 @@ public boolean updateSettings()
 		//save sync and defaultTitle checkbox-states
 		editor.putBoolean(PREF_AUTOSYNC, autoSync.isChecked());
 		editor.putBoolean(PREF_DEFAULT_TITLE, defaultTitle.isChecked() );
+		editor.putBoolean(PREF_EXTENSIVE_LOG, extensiveLogCat.isChecked() );
 		editor.putBoolean(PREF_INITIALIZED, true);
 
 		editor.commit();
@@ -189,8 +191,7 @@ public boolean isValidUsername(EditText toCheck)
 	public boolean containsForbiddenSymbols(String toCheck, char... chars)
 	{
 		if(	toCheck.indexOf(chars[0]) != -1 ||	// "
-			toCheck.indexOf(chars[1]) != -1		// '
-		  )
+			toCheck.indexOf(chars[1]) != -1 )   // '
 		{
 			return true;
 		}