Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Translations needed! #5

Open
azagaya opened this issue Aug 19, 2019 · 19 comments
Open

Translations needed! #5

azagaya opened this issue Aug 19, 2019 · 19 comments
Labels
help wanted Extra attention is needed

Comments

@azagaya
Copy link
Owner

azagaya commented Aug 19, 2019

Laigter is currently translated into spanish and english.
If anyone wants to translate it to another language, it would be very helpful! Just post here and i'll contact you.

@azagaya azagaya added the help wanted Extra attention is needed label Aug 19, 2019
@flamendless
Copy link
Contributor

I'm willing to translate it to Filipino (Philippine language)

@azagaya
Copy link
Owner Author

azagaya commented Aug 19, 2019

@flamendless that would be great! You have this options:

  • If you are familiar with Qt, just use lerelease, lupdate and linguist to create the corresponding translation file (if phi is the prefix, it would be laigter_phi.ts).

  • If you are not familiar with Qt, you can clone laigter's repo, copy laigter_en.ts to laigter_phi.ts and replace everything between by the equivalent in philipine. Then make a pull request and i'll manage to get it working inside Qt app. Just don't translate the text in akcnowledgemets, as it woud take a lot and is not important it to be in other languages.

@flamendless
Copy link
Contributor

flamendless commented Aug 19, 2019

I'd probably do the latter as I haven't yet downloaded QT creator. Also, PH is the suffix I will use

Sent from my HUAWEI GR5 2017 using FastHub

@azagaya
Copy link
Owner Author

azagaya commented Sep 25, 2019

@Calinou I've changed all base text and internal strings to english, so i had to pass your translations to another file with english strings as originals. I think some characters broke, and also some new strings appeared due to #10. If you have some spare time, would you check it?

@kusogaki77
Copy link
Contributor

Hi! I can do the Japanese translation. You'd have to support Unicode characters though. Not sure if they're already supported...

@Calinou
Copy link
Contributor

Calinou commented Apr 6, 2020

@kusogaki77 They should already be supported, as the application is rendered using the system font as provided by Qt.

@azagaya
Copy link
Owner Author

azagaya commented Apr 6, 2020

@kusogaki77 Hi!
Thanks for offering your help! If you are used to Qt, you can use QtLinguist to easily add a new translation. If not, for the repository, copy the translations/laigter_en.ts file into a renamed file with your locale sufix, and translate each tag between the <translation></translation> tags. I can add the rest myself, or guide you through the process if you need.

@kusogaki77
Copy link
Contributor

kusogaki77 commented Apr 7, 2020

@azagaya Some translation tags have type="unfinished". If I translate it, should I remove it?

Edit: I removed type="unfinished" from all of those I translated.
Seems I don't have permission to push. I'll try to fork it and send a PL.

Edit 2: I sent a pull request for the initial jp translations.

@azagaya
Copy link
Owner Author

azagaya commented Apr 7, 2020

Hi! Thanks a lot! I'll check it as soon as i get some free time. I could send you a build with the language for you to test. Are you on windows or linux? If you are no MAC, i'm sorry but i don't have a MAC at home, and with the quarantine i cannot go out.

@azagaya
Copy link
Owner Author

azagaya commented Apr 7, 2020

Sorry for the late response, it was late night here when you commented.

@kusogaki77
Copy link
Contributor

kusogaki77 commented Apr 7, 2020 via email

@azagaya
Copy link
Owner Author

azagaya commented Apr 8, 2020

@kusogaki77 i'm sorry i couldnt make the binaries yesterday, i was too busy. Anyways, i'm adding some new strings due to project save/load. It would be nice if you could wait a couple of days and then add the translations to those few remaining strings, and then i'll send you the build. What do you think? if not, i can try to send you the build tomorrow.

@kusogaki77
Copy link
Contributor

@azagaya Np at all. I will wait until the new save/load strings are added. I'm not very good with github. I'm not sure if I need to stop my pull request in order to submit another updated version of the ***jp.ts file again w/ the new strings.

jsyk, I forked your engine, duplicated the ***en.ts file, renamed it to ***jp.ts, added the translations and then committed it to my fork using smartgit. After that I submitted the PR directly to your repo via my fork on github.

@azagaya
Copy link
Owner Author

azagaya commented Apr 9, 2020

@kusogaki77 you don't need to stop the pull request. If you need to add/change anything, just commit new changes to your repo, and the PR will update. So when i send you the binaries to test, you can only change/add what is needed and commit again.

@kusogaki77
Copy link
Contributor

kusogaki77 commented Apr 14, 2020

@azagaya I synced to your latest repo (as of 12 hours ago). Running the app with the binaries you provided me, I fixed a few translations to be more natural, and added some missing translations. Afaict, everything is translated. I didn't see any additional strings that weren't there when I had initially submitted the PL.

@azagaya
Copy link
Owner Author

azagaya commented Apr 14, 2020

@kusogaki77 Hi ! thanks!
Its strange that you got no new strings... perhaps i forgot to update the translations files?
Well.. if its ok with you, i'll merge the PR, and perhaps we could add missing translations for next releaes. How would you like to appear in credits? I add all translators in a list in the about dialog.

@IceinNorth
Copy link

I would like to ask about the Chinese translation, I selected Chinese in Language, but it does not work, the interface is still in English

@IceinNorth
Copy link

我想询问一下中文翻译,我选择了 Chinese in Language,但它不起作用,界面仍然是英文的

I noticed that the laigter_zh_CN.ts was fixed 6 months ago, but the latest 1.11 version in the release was indeed released last year, maybe a new release is needed?

@azagaya
Copy link
Owner Author

azagaya commented Oct 11, 2024

@IceinNorth i replied on the other thread, im working on a release, but i really need to fix a couple issues before.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants