From 1cd0d536ee17efbca02e1ddab5c7e559cf558422 Mon Sep 17 00:00:00 2001 From: Hector Castro Date: Mon, 29 Apr 2019 10:56:13 -0400 Subject: [PATCH 1/2] Fix ref to taskDefinition in describe_task_definition response The response for `describe_task_definition` contains several top-level keys, one of which is `taskDefinition`. In order to get task definition specific attributes (e.g., `networkMode`), the top-level `taskDefinition` key needs to be retrieved and assigned to `task_def`. --- ecsmanage/management/commands/ecsmanage.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ecsmanage/management/commands/ecsmanage.py b/ecsmanage/management/commands/ecsmanage.py index 5ecfc40..8f43f41 100644 --- a/ecsmanage/management/commands/ecsmanage.py +++ b/ecsmanage/management/commands/ecsmanage.py @@ -160,7 +160,9 @@ def run_task(self, config, task_def_arn, security_group_id, subnet_id, cmd): """ overrides = {"containerOverrides": [{"name": "django", "command": cmd}]} - task_def = self.ecs_client.describe_task_definition(taskDefinition=task_def_arn) + task_def = self.ecs_client.describe_task_definition( + taskDefinition=task_def_arn + )["taskDefinition"] # Only the awsvpc network mode supports the networkConfiguration # input value. From 3adebc7ddbb17b1dbdb6986abb5552bf6d36339a Mon Sep 17 00:00:00 2001 From: Hector Castro Date: Mon, 29 Apr 2019 11:40:27 -0400 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ae0d66..155dcf2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,11 +5,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Fixed +- Fixed reference to taskDefinition in describe_task_definition response [#5](https://github.com/azavea/django-ecsmanage/pull/5) ## [0.1.0] - 2019-04-10 ### Added -- Update PyPi credentials [\#4](https://github.com/azavea/django-ecsmanage/pull/4) -- Initialize Django module for one-off management commands [\#2](https://github.com/azavea/django-ecsmanage/pull/2) +- Update PyPi credentials [#4](https://github.com/azavea/django-ecsmanage/pull/4) +- Initialize Django module for one-off management commands [#2](https://github.com/azavea/django-ecsmanage/pull/2) -[Unreleased]: https://github.com/azavea/django-ecsmanage/compare/0.1.0...HEAD +[unreleased]: https://github.com/azavea/django-ecsmanage/compare/0.1.0...HEAD [0.1.0]: https://github.com/azavea/django-ecsmanage/releases/tag/0.1.0