From 9c43adc445bae58233cf21e99155d2ff9184db53 Mon Sep 17 00:00:00 2001 From: Kitzunu <24550914+Kitzunu@users.noreply.github.com> Date: Sun, 19 Jan 2025 20:31:54 +0100 Subject: [PATCH] fix(Core/ObjectMgr): Potential crash in GetModuleString() (#21211) --- src/server/game/Globals/ObjectMgr.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/game/Globals/ObjectMgr.cpp b/src/server/game/Globals/ObjectMgr.cpp index 423db19e13f266..f2bc1fe4b28ac7 100644 --- a/src/server/game/Globals/ObjectMgr.cpp +++ b/src/server/game/Globals/ObjectMgr.cpp @@ -8688,7 +8688,7 @@ bool ObjectMgr::LoadModuleStringsLocale() std::string const* ObjectMgr::GetModuleString(std::string module, uint32 id, LocaleConstant locale) const { ModuleString const* ms = GetModuleString(module, id); - if (ms->Content.size()) + if (ms && !ms->Content.empty()) { if (ms->Content.size() > size_t(locale) && !ms->Content[locale].empty()) return &ms->Content[locale];