[Server] world carsh cased by patch "Dreghood Brute dont become friendly after the death of the taskmaster"

[kissingers]

Current Behaviour

Update
Now I can 100% replay the crash.

.go xyz -445.000153 4747.521 19.9338989
First kill the two creature 16937
Then kill the creature 17058
The SAI can't do action for creature 16937, because it is died. server crash.

Here is gdb.txt log, I guest it about some creature movement. I dont know how to collect log, only have gdb log below.

gdb.zip

update 1116 carsh log and dberror log
gdb.txt
DBErrors.log

Expected Blizzlike Behaviour

N/A

Source

No response

Steps to reproduce the problem

N/A

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. 5cf7d3d+ 2022-11-13 18:41:10 -0300 (HEAD branch) (Unix, RelWithDebInfo, Static)
Using SSL version: OpenSSL 1.1.1n 15 Mar 2022 (library: OpenSSL 1.1.1n 15 Mar 2022)
Using Boost version: 1.74.0
Using MySQL version: 100515
Using CMake version: 3.18.4
Compiled on: Linux 5.15.64-1-pve
Worldserver listening connections on port 54345
Realmlist (Realm Id: 1) configured in port 54345
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in /root/wow/bin/maps. Total size: 291014339 bytes
vmaps directory located in /root/wow/bin/vmaps. Total size: 658130553 bytes
mmaps directory located in /root/wow/bin/mmaps. Total size: 2320900760 bytes
Using zhCN DBC Locale as default. All available DBC locales: zhCN
Using World DB: ACDB 335.8-dev
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0

List enable modules:

• mod-anticheat
• mod-bg-reward
• mod-cfbg
• mod-eluna
• mod-multi-client-check
• mod-npc-beastmaster
• mod-pvp-titles
• mod-server-auto-shutdown

Operating system

debian 11 x64

Custom changes or Modules

No response

[kissingers]

update log 1117
gdb1117.zip

[kissingers]

I know what problem case the carsh, becasue the smartscript update
368a363 09/11/2022 patch for creature 17058

the carsh xyz here:
.go xyz -445.000153 4747.521 19.9338989
.go xyz -441.082275 4847.5893 27.9839478
.go xyz -441.946442 4841.73389 26.9893818
.go xyz -442.375397 4846.8833 28.0495949
.go xyz -456.164551 4673.1123 31.0895805

the new AI will ,but no always case the problem.

UPDATE creature_template SET AIName = 'SmartAI' WHERE entry = 17058;

DELETE FROM smart_scripts WHERE (entryorguid = 17058) AND (source_type = 0) AND (id IN (0, 1, 2, 3, 4, 5, 6, 7));
INSERT INTO smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_param4, target_x, target_y, target_z, target_o, comment) VALUES
(17058, 0, 0, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 36, 19477, 0, 0, 0, 0, 0, 9, 16938, 0, 20, 1, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Update Template To 'Fleeing Dreghood Warrior''),
(17058, 0, 1, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 36, 19477, 0, 0, 0, 0, 0, 9, 16937, 0, 20, 1, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Update Template To 'Fleeing Dreghood Warrior''),
(17058, 0, 2, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 2, 15, 0, 0, 0, 0, 0, 9, 19477, 0, 20, 0, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Set Faction 15'),
(17058, 0, 3, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 17, 470, 0, 0, 0, 0, 0, 9, 19477, 0, 20, 1, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Set Emote State 470'),
(17058, 0, 4, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 24, 0, 0, 0, 0, 0, 0, 9, 19477, 0, 20, 1, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Evade'),
(17058, 0, 5, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 9, 19477, 0, 20, 1, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Say Line 0'),
(17058, 0, 6, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 89, 10, 0, 0, 0, 0, 0, 9, 19477, 0, 20, 1, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Start Random Movement'),
(17058, 0, 7, 0, 6, 0, 100, 0, 0, 0, 0, 0, 0, 41, 10000, 0, 0, 0, 0, 0, 9, 19477, 0, 20, 1, 0, 0, 0, 0, 'Illidari Taskmaster - On Just Died - Despawn In 10000 ms');

so I roll back the smartscript AI before

INSERT INTO acore_world.smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_param4, target_x, target_y, target_z, target_o, comment) VALUES (17058, 0, 0, 0, 2, 0, 100, 1, 0, 20, 0, 0, 0, 11, 34186, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Illidari Taskmaster - Between 0-20% Health - Cast 'Haste Other' (No Repeat)');
INSERT INTO acore_world.smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_param4, target_x, target_y, target_z, target_o, comment) VALUES (17058, 0, 1, 0, 0, 0, 75, 0, 2000, 2000, 16000, 16000, 0, 11, 16244, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 'Illidari Taskmaster - In Combat - Cast 'Demoralizing Shout' (No Repeat)');
INSERT INTO acore_world.smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_param4, target_x, target_y, target_z, target_o, comment) VALUES (17058, 0, 2, 0, 4, 0, 100, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 'Illidari Taskmaster - On Agro - Say');
INSERT INTO acore_world.smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_param4, target_x, target_y, target_z, target_o, comment) VALUES (17058, 0, 3, 0, 1, 0, 100, 0, 15000, 60000, 45000, 90000, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Illidari Taskmaster - OOC - Say');

[kissingers]

I think fix smart_scripts cpp to prevent this type of crash is more good than only fix this SAI self.