Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Relative links are not working #4

Open
BarbzYHOOL opened this issue Jul 13, 2018 · 2 comments
Open

Relative links are not working #4

BarbzYHOOL opened this issue Jul 13, 2018 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@BarbzYHOOL
Copy link
Member

Example: http://www.azerothcore.org/modules-catalogue/details.html?id=113089469

From @deku "because it is using a relative path, and not a full URL, we could add a little handler for relative paths"

@BarbzYHOOL BarbzYHOOL added the bug Something isn't working label Jul 13, 2018
@ZeegCL ZeegCL self-assigned this Jul 14, 2018
@ZeegCL
Copy link
Contributor

ZeegCL commented Jul 14, 2018

We could either warn the developers to use only full paths or use the handler. Including a handler ourselves could be a little trickier than expected.

I was thinking on pre-processing the README contents before Markdown, searching for all the image tags and checking the relative paths with some regex and then replacing them with the "https://raw.github.com/........"

@BarbzYHOOL
Copy link
Member Author

Sounds good, you decide anyway. To embed images, all tutorials for github markdown say to use relative path, that's why it's a bit annoying

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants