Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Does bbin support installing multiple libraries from bb.edn? #59

Open
teodorlu opened this issue Mar 8, 2023 · 3 comments
Open

Does bbin support installing multiple libraries from bb.edn? #59

teodorlu opened this issue Mar 8, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@teodorlu
Copy link
Contributor

teodorlu commented Mar 8, 2023

Since :bbin/bin is a map, I assumed installing multiple binaries was okay:

{:deps {io.github.teodorlu/shed {:local/root "."}}
 :bbin/bin {update-repos {:main-opts ["-m" "teodorlu.shed.update-repos/-main"]}
            browsetxt {:main-opts ["-m" "teodorlu.shed.browsetxt/-main"]}}}

(source)

But this seems to only install update-repos. Originally asked on Slack.


Should bbin be able to install multiple binaries, and not just one?

@borkdude
Copy link
Contributor

borkdude commented Mar 8, 2023

I think this could be improved. PR welcome if @rads agrees.

@teodorlu
Copy link
Contributor Author

teodorlu commented Mar 8, 2023

The first key-value pair is picked in a (some-> bin-config first key str) here. Looks like the rest of the install-deps-git-or-local function assumes that script-name is one script and not multiple scripts.

https://github.com/teodorlu/bbin/blob/6b778266a490a4d0d89618a60bffc9617f62e7e3/src/babashka/bbin/scripts.clj#L413-L417

@rads
Copy link
Collaborator

rads commented Mar 9, 2023

Yep, the map is intentional to support multiple scripts, though I haven't gotten around to implementing that quite yet. See also:

@rads rads added the enhancement New feature or request label Jun 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants