New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Consider switching from `util.promisify` to `pify`. #743

Closed

wtgtybhertgeghgtwtg opened this issue Dec 5, 2018 · 0 comments · Fixed by #785

wtgtybhertgeghgtwtg commented Dec 5, 2018 •

edited

Loading

Current behavior:
babel-loader uses util.promisify to promisify a callback function.

Expected/desired behavior:
babel-loader uses pify to promisify a callback function.

What is the motivation / use case for changing the behavior?
babel-loader already pulls in pify from find-cache-dir. Using that would shave 13 packages off of the dependency tree, for a net reduction of about 442 kb from the install size.

I'd be happy to file a PR.

The text was updated successfully, but these errors were encountered:

alexander-akait mentioned this issue

chore: migrate on pify #785

Merged

11 tasks

danez closed this as completed in #785

# for free to join this conversation on GitHub. Already have an account? # to comment