Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #576 #587

Merged
merged 6 commits into from
Jun 19, 2017
Merged

Fix #576 #587

merged 6 commits into from
Jun 19, 2017

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jun 16, 2017

People were calling "foo".toString() or ["foo", "bar"].toString(), which returned the real JS string "[object Object]", the stringified version of the replacements object. Fixes #576.


I just noticed this:

[foo, bar].toString() // is longer than
[foo, bar].join(',')

j-f1 added 2 commits June 16, 2017 06:08
People were calling `"foo".toString() or ["foo", "bar"].toString()`, which returned the real JS string `"[object Object]"`, the stringified version of the replacements object.
@codecov
Copy link

codecov bot commented Jun 17, 2017

Codecov Report

Merging #587 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage    82.8%   82.83%   +0.03%     
==========================================
  Files          44       44              
  Lines        2896     2896              
  Branches     1011     1011              
==========================================
+ Hits         2398     2399       +1     
+ Misses        304      303       -1     
  Partials      194      194
Impacted Files Coverage Δ
.../babel-plugin-minify-constant-folding/src/index.js 85.56% <100%> (ø) ⬆️
packages/babel-plugin-minify-simplify/src/index.js 80.74% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba29bc5...742e3b2. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 17, 2017

Codecov Report

Merging #587 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage    82.8%   82.98%   +0.18%     
==========================================
  Files          44       44              
  Lines        2896     2898       +2     
  Branches     1011     1013       +2     
==========================================
+ Hits         2398     2405       +7     
+ Misses        304      302       -2     
+ Partials      194      191       -3
Impacted Files Coverage Δ
.../babel-plugin-minify-constant-folding/src/index.js 89.89% <100%> (+4.33%) ⬆️
packages/babel-plugin-minify-simplify/src/index.js 80.74% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba29bc5...5c7ff9b. Read the comment docs.

@boopathi
Copy link
Member

Thanks. Can you also add a test for this ?

@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Jun 18, 2017
@j-f1
Copy link
Contributor Author

j-f1 commented Jun 18, 2017

@boopathi Test added.

@damianobarbati
Copy link

any chance to merge this in master soon? production build broken for many! 😱

@vigneshshanmugam vigneshshanmugam merged commit 38b7740 into babel:master Jun 19, 2017
@vigneshshanmugam
Copy link
Member

We will release a new version today with this fix.

@j-f1 j-f1 deleted the patch-2 branch June 19, 2017 10:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants