Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Versioning of plugins vs CLI #139

Open
Daniel15 opened this issue Sep 1, 2016 · 5 comments
Open

Versioning of plugins vs CLI #139

Daniel15 opened this issue Sep 1, 2016 · 5 comments

Comments

@Daniel15
Copy link
Member

Daniel15 commented Sep 1, 2016

Is the CLI versioned separately to the plugins? As an example, babel-plugin-minify-dead-code-elimination was changed more recently than babili, yet babel-plugin-minify-dead-code-elimination in the repo has a version number of 0.0.1 while babili has 0.0.4.

@hzoo
Copy link
Member

hzoo commented Sep 1, 2016

Right now we are using independent mode from lerna so yes #120

@Daniel15
Copy link
Member Author

Daniel15 commented Sep 1, 2016

So are there two separate version numbers (one for plugins and one for the CLI), or does every plugin have its own separate version number?

For babel-standalone, how should I version the Babili releases? Right now for Babel release I'm getting the maximum version number of all the babel-* packages, but maybe that won't work for Babili if everything is versioned independently.

@hzoo
Copy link
Member

hzoo commented Sep 1, 2016

https://github.com/lerna/lerna#how-it-works Right now each package in packages/ has it's own number

Maybe we should look into updating the cli/preset each time any of the plugins update (or switch back to the other mode like in babel)

@Daniel15
Copy link
Member Author

Daniel15 commented Sep 4, 2016

Yeah I think it's advantageous to have one version number for Babili. Every plugin having its own version number is a bit confusing 😄

@vikramaroskar
Copy link

Not much expertise on babel* yet. but in general having separate versioning does have its own advantages, and I prefer this in general. My 2 cents. There is a case for updating versions synchronously.
A small caveat: A similar thing happening with Angular (they're dropping v3 and jumping to 4)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants