Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add getAllDependents and getAllDependencies method to the DependencyGraph class #36113

Closed
sameerajayasoma opened this issue May 12, 2022 · 9 comments · Fixed by #41561
Closed
Assignees
Labels
Area/ProjectAPI good first issue Hacktoberfest Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Improvement

Comments

@sameerajayasoma
Copy link
Contributor

https://github.com/ballerina-platform/ballerina-lang/blob/master/compiler/ballerina-lang/src/main/java/io/ballerina/projects/DependencyGraph.java

    // Returns all direct and indirect dependents of the node T
    public Collection<T> getAllDependents(T node) {
    }

    // Returns all direct and indirect dependencies of node T 
    public Collection<T> getAllDependencies(T node) {
    }
@shreyajha03
Copy link

@sameerajayasoma Can I please take this issue ?
Thanks!

@adripo
Copy link
Contributor

adripo commented Oct 23, 2023

@keizer619 @sameerajayasoma can I please be assigned to this issue? There have been no updates for 3 weeks

@adripo
Copy link
Contributor

adripo commented Oct 23, 2023

@keizer619 @sameerajayasoma I created a PR for the issue. If Shreya comes back with a PR, please just ignore mine. Thanks

@keizer619 keizer619 assigned adripo and unassigned shreyajha03 Oct 26, 2023
@adripo
Copy link
Contributor

adripo commented Oct 26, 2023

Thanks @keizer619
Can you please run the workflows on my PR?

@keizer619 keizer619 moved this from Todo to PR Sent in Hacktoberfest 2023 Nov 1, 2023
@keizer619
Copy link
Member

Thanks @keizer619 Can you please run the workflows on my PR?

There are some test failures.

@adripo
Copy link
Contributor

adripo commented Nov 3, 2023

@keizer619 I made some confusion in the tests, bot now they're all fixed. Please re-run the checks.

@adripo
Copy link
Contributor

adripo commented Nov 7, 2023

@sameerajayasoma @keizer619 I see that CI Windows still fails, but I don't know why. Could you have a look please?

@azinneera
Copy link
Contributor

@sameerajayasoma @keizer619 I see that CI Windows still fails, but I don't know why. Could you have a look please?

@adripo These are some intermittent test failures. We have fixed it now. Can you rebase your PR with the master branch?

@adripo
Copy link
Contributor

adripo commented Nov 23, 2023

@azinneera I resynced with master, please run the workflows again.

@github-project-automation github-project-automation bot moved this from PR Sent to Done in Hacktoberfest 2023 Nov 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area/ProjectAPI good first issue Hacktoberfest Team/DevTools Ballerina Developer Tooling ( CLI, Test FW, Package Management, OpenAPI, APIDocs ) Type/Improvement
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants