Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bang methods #84

Open
samandmoore opened this issue Jun 19, 2017 · 1 comment
Open

bang methods #84

samandmoore opened this issue Jun 19, 2017 · 1 comment

Comments

@samandmoore
Copy link
Contributor

Hi there,

I'm curious if you'd be open to a PR (or possibly a few PRs) to add a suite of bang methods like #save!, .create!. These methods would provide the same base behavior as their non-bang versions but in the event of a local or remote validation error, they would raise a special exception, e.g. ResourceNotValid. These bang methods are intended to be the equivalent of the ActiveRecord bang methods.

At Betterment we use the Her gem quite a bit and have actually privately forked it and extended it with a lot of functionality, specifically including these bang methods. I'd like to try to migrate off of Her and onto Spyke. This change would go a long way to making Spyke work for our use-cases.

Thanks for creating this library and thanks for your time!

@balvig
Copy link
Owner

balvig commented Jun 19, 2017

@samandmoore adding those sounds reasonable to me! Thanks for checking out the gem :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants