[BUG]: 创建收藏遇到unique index 重复的问题

[trim21]

暂时还没没找到复现，但是有不少日志错误

对应的请求是用户 730066 用 post 请求想要收藏 335225

Error 1062 (23000): Duplicate entry '730066-335225' for key 'user_interest'
error stack:
github.com/bangumi/server/internal/collections/infra.mysqlRepo.updateOrCreateSubjectCollection
	github.com/bangumi/server/internal/collections/infra/mysql_repo.go:162
github.com/bangumi/server/internal/collections/infra.mysqlRepo.UpdateOrCreateSubjectCollection
	github.com/bangumi/server/internal/collections/infra/mysql_repo.go:117
github.com/bangumi/server/ctrl.Ctrl.UpdateSubjectCollection
	github.com/bangumi/server/ctrl/update_subject_collection.go:58
github.com/bangumi/server/web/handler/user.User.updateOrCreateSubjectCollection
	github.com/bangumi/server/web/handler/user/patch_subject_collection.go:93
github.com/bangumi/server/web/handler/user.User.PostSubjectCollection
	github.com/bangumi/server/web/handler/user/post_subject_collection.go:43
github.com/bangumi/server/web/mw.NeedLogin.func1
	github.com/bangumi/server/web/mw/middleware.go:32
github.com/bangumi/server/web/req.JSON.func1
	github.com/bangumi/server/web/req/content_type.go:29
github.com/bangumi/server/web/handler/common.Common.MiddlewareAccessTokenAuth.func1
	github.com/bangumi/server/web/handler/common/access_token.go:63
github.com/labstack/echo/v4.(*Echo).add.func1
	github.com/labstack/echo/v4@v4.10.2/echo.go:575
github.com/bangumi/server/web/mw/ua.DisableDefaultHTTPLibrary.func1
	github.com/bangumi/server/web/mw/ua/new.go:42
github.com/bangumi/server/web/mw/recovery.New.func1.1
	github.com/bangumi/server/web/mw/recovery/new.go:54
github.com/bangumi/server/web.New.func3.1
	github.com/bangumi/server/web/new.go:100
github.com/labstack/echo/v4/middleware.CORSWithConfig.func1.1
	github.com/labstack/echo/v4@v4.10.2/middleware/cors.go:199
github.com/bangumi/server/web.New.func2.1
	github.com/bangumi/server/web/new.go:68
github.com/labstack/echo/v4.(*Echo).ServeHTTP
	github.com/labstack/echo/v4@v4.10.2/echo.go:662
net/http.serverHandler.ServeHTTP
	net/http/server.go:2936

@RanKKI

[RanKKI]

可能是并发的问题？

代码似乎没有问题，
看看是不是同一请求发送两次？然后加锁

[trim21]

看了一下请求日志，也不是同一个请求发了两次

[RanKKI]

加上 trace 之后这两天有无新的发现

[trim21]

没有相同的报错了... 先close了

[RanKKI]

真奇怪....

[trim21]

rror stack:
github.com/bangumi/server/internal/collections/infra.mysqlRepo.updateOrCreateSubjectCollection
	github.com/bangumi/server/internal/collections/infra/mysql_repo.go:156
github.com/bangumi/server/internal/collections/infra.mysqlRepo.UpdateOrCreateSubjectCollection
	github.com/bangumi/server/internal/collections/infra/mysql_repo.go:117
github.com/bangumi/server/ctrl.Ctrl.UpdateSubjectCollection
	github.com/bangumi/server/ctrl/update_subject_collection.go:58
github.com/bangumi/server/web/handler/user.User.updateOrCreateSubjectCollection
	github.com/bangumi/server/web/handler/user/patch_subject_collection.go:93
github.com/bangumi/server/web/handler/user.User.PostSubjectCollection
	github.com/bangumi/server/web/handler/user/post_subject_collection.go:43
github.com/bangumi/server/web/mw.NeedLogin.func1
	github.com/bangumi/server/web/mw/middleware.go:32
github.com/bangumi/server/web/req.JSON.func1
	github.com/bangumi/server/web/req/content_type.go:29

[trim21]

server/internal/collections/infra/mysql_repo.go

Line 156 in d8d246b

err = errgo.Trace(T.WithContext(ctx).Create(obj))

这里

[trim21]

看起来像是

server/internal/collections/infra/mysql_repo.go

Line 110 in d8d246b

s, err := r.getSubjectCollection(ctx, userID, subject.ID)

这里的问题，两个请求并发不安全

[RanKKI]

所以是两个请求一起进来么？

[trim21]

是的，看日志应该是

[RanKKI]

加个锁吧，我晚点提个 pr