Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add env selector to provider implementations #137

Closed
ramizpolic opened this issue May 13, 2024 · 0 comments · Fixed by #203
Closed

Add env selector to provider implementations #137

ramizpolic opened this issue May 13, 2024 · 0 comments · Fixed by #203
Assignees
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.

Comments

@ramizpolic
Copy link
Member

The provider logic is broken into two places: a) for selecting secrets from ENV and b) for loading required secrets loaded from env.
We can add Valid(envKey, envValue string) bool method to providers which can be used to decide which provider to use when loading secrets.

The provider initialization logic should be also be adjusted so that we can loop/lookup available providers in order to test env-secret validity.

Further clarify and have proper planning meeting before working on this.

@csatib02 csatib02 added the kind/enhancement Categorizes issue or PR as related to an improvement. label May 25, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jul 28, 2024
@csatib02 csatib02 added lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jul 28, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jul 28, 2024
@csatib02 csatib02 self-assigned this Jul 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants