-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reduce the test matrix #135
Comments
While I agree that a bug in another repo should be caught there, I don't see how reducing the matrix should solve this issue, the time for the checks wouldn't really decrease as they are executed in parallel. Maybe we could put the same acceptance test in the bank-vaults repo as well, and use a pinned version of the operator in bank-vaults, a pinned version of bank-vaults in the operator and only update them when it is known for that version that it passes its checks? |
There is a limit on the amount of concurrent jobs we can run, so they don't all run parallel. We often have to wait for a set of jobs to complete before the next ones can launch. |
Oh I didn't notice that, just assumed that a rolling yellow circle means it is in progress! |
Thank you for your contribution! This issue has been automatically marked as |
The current test matrix tests the operator on all supported Kubernetes versions with all supported Vault versions. However, for the operator we really should be testing Kubernetes compatibility, not Vault compatibility.
Although the Bank-Vaults CLI has way less integration tests (something we should probably change), failing an integration test due to a bug in Bank-Vaults itself does not mean anything from the operator's perspective.
I suggest reducing the test matrix in PRs to all supported Kubernetes versions and the latest Vault version.
We can keep running tests for all supported Vault versions on merges and in nightly builds, to make sure we catch integration errors, but I think we should reduce the size of the matrix in PRs.
WDYT?
@akijakya @ramizpolic
The text was updated successfully, but these errors were encountered: