Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

[BUG] Multivariate channel initialisation on v0.2.6 #44

Closed
1 task done
baraline opened this issue Mar 16, 2023 · 1 comment · Fixed by #45
Closed
1 task done

[BUG] Multivariate channel initialisation on v0.2.6 #44

baraline opened this issue Mar 16, 2023 · 1 comment · Fixed by #45
Labels
bug Something isn't working

Comments

@baraline
Copy link
Owner

baraline commented Mar 16, 2023

In some case, shapelet initialization for multivariate time series return mostly channel 0. The problem is removed by setting Numba parallel to False.

  • Find the origin of the bug in the multivariate initialization with parallel option to True.
@baraline baraline added the bug Something isn't working label Mar 16, 2023
@baraline baraline changed the title [BUG] Multivariate channel initalisation [BUG] Multivariate channel initialisation Mar 16, 2023
@baraline
Copy link
Owner Author

baraline commented Mar 16, 2023

The bug is due to the index variables a1/a2 used to affect channel values to the channel parameter array. This operation is not safe for parallel processing, as a1 and a2 can be concurrently modified by each thread.

  • Modify indexing scheme for multivariate shapelet transformers to allow for parallel initialisation in a thread-safe manner

@baraline baraline pinned this issue Mar 16, 2023
@baraline baraline linked a pull request Mar 16, 2023 that will close this issue
@baraline baraline changed the title [BUG] Multivariate channel initialisation [BUG] Multivariate channel initialisation on v0.2.6 Mar 16, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant