error when using composite key package

[MartinP7r]

#706 seems related

I'm using awobaz/compoships (https://github.com/topclaudy/compoships) for a relationship that uses composite keys in one of my models, which seems to break the generation script for models as it throws the following error:

Exception: Illegal offset type in isset or empty
Could not analyze class App\ClassName.

the breaking composite key relationship looks like this:

public function department()
{
    return $this->hasOne(
        Department::class,
        ['company_id', 'department_id'],
        ['company_id', 'department_id']
    );
}

I realize that you can't account for 3rd party packages, but would there be a workaround way to at least exclude the relationship from scanning?

[mpyw]

@MartinP7r (CC @barryvdh)

Quick fix for this issue (requires barryvdh/laravel-ide-helper^2.7 php>=7.4):

<?php

namespace App\Console\Commands\IdeHelper;

use Barryvdh\LaravelIdeHelper\Console\ModelsCommand as BaseModelsCommand;
use Illuminate\Support\Arr;
use Illuminate\Database\Eloquent\Relations\Relation;

class ModelsCommand extends BaseModelsCommand
{
    /**
     * @param  string   $relation
     * @param  Relation $relationObj
     * @return bool
     */
    protected function isRelationNullable(string $relation, Relation $relationObj): bool
    {
        $reflectionObj = new \ReflectionObject($relationObj);

        if (in_array($relation, ['hasOne', 'hasOneThrough', 'morphOne'], true) || !$reflectionObj->hasProperty('foreignKey')) {
            return parent::isRelationNullable($relation, $relationObj);
        }

        $fkProp = $reflectionObj->getProperty('foreignKey');
        $fkProp->setAccessible(true);

        return (bool)Arr::first(
            (array)$fkProp->getValue($relationObj),
            fn (string $value) => isset($this->nullableColumns[$value])
        );
    }
}

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

[musznik]

error stil exist in "barryvdh/laravel-ide-helper": "^2.10" and "awobaz/compoships": "^2.1",

Trace:

Exception: Illegal offset type in isset or empty
Could not analyze class App\Models\MyModel.

#0 \barryvdh\laravel-ide-helper\src\Console\ModelsCommand.php(772): Illuminate\Foundation\Bootstrap\HandleExceptions->handleError(2, 'Illegal offset ...', '--', 772, Array)
#1 \barryvdh\laravel-ide-helper\src\Console\ModelsCommand.php(734): Barryvdh\LaravelIdeHelper\Console\ModelsCommand->isRelationNullable('belongsTo', Object(Awobaz\Compoships\Database\Eloquent\Relations\BelongsTo))

Model:

class FirstModel extends Model
{
    use \Awobaz\Compoships\Compoships;

    function commune(){
        return  $this->belongsTo(SecondayModel::class,['WOJ','POW','GMI'],['WOJ','POW','GMI']);
    }
}

[maned3v]

I'm facing the same problem in version 2.10 and solved by checking each compoships array key element:

...\web\vendor\barryvdh\laravel-ide-helper\src\Console\ModelsCommand.php

protected function isRelationNullable(string $relation, Relation $relationObj): bool
    {
        $reflectionObj = new ReflectionObject($relationObj);

        if (in_array($relation, ['hasOne', 'hasOneThrough', 'morphOne'], true)) {
            $defaultProp = $reflectionObj->getProperty('withDefault');
            $defaultProp->setAccessible(true);

            return !$defaultProp->getValue($relationObj);
        }

        if (!$reflectionObj->hasProperty('foreignKey')) {
            return false;
        }

        $fkProp = $reflectionObj->getProperty('foreignKey');
        $fkProp->setAccessible(true);

        //Compoships
        if (is_array($fkProp->getValue($relationObj))) {
            foreach ($fkProp->getValue($relationObj) as $key) if (!isset($this->nullableColumns[$key])) return false;
            return true;
        }

        return isset($this->nullableColumns[$fkProp->getValue($relationObj)]);
    }