Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Go module not included for well known type: googleapis/type/date #449

Closed
Tom-Hudson opened this issue Dec 4, 2024 · 3 comments · Fixed by #450
Closed

Go module not included for well known type: googleapis/type/date #449

Tom-Hudson opened this issue Dec 4, 2024 · 3 comments · Fixed by #450
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Tom-Hudson
Copy link

When a proto uses a googleapis/type/date type, the proto is already bundled in the docker image but not the go module, so when trying to start the server, you get this error:

2024-12-04T07:38:07Z INF Starting GripMock release=v2.7.0
2024-12-04T07:38:07Z INF stub-manager started addr=0.0.0.0:4771
2024-12-04T07:38:07Z INF gRPC-service started pid=47
protogen/proto/example.pb.go:11:2: no required module provides package google.golang.org/genproto/googleapis/type/date; to add it:
        go get google.golang.org/genproto/googleapis/type/date
2024/12/04 07:38:08 exit status 1

I am currently building a mock image bundled with stubs for reuse, so to fix this, I added a RUN go get google.golang.org/genproto/googleapis/type/date step to Dockerfile to get the dependency in the container and everything just worked. I feel since the well known type protos are already bundled then the modules to make them work should be too.

Thank for this fork, it's brilliant and solves some real headaches!

@rez1dent3 rez1dent3 self-assigned this Dec 4, 2024
@rez1dent3 rez1dent3 linked a pull request Dec 4, 2024 that will close this issue
@rez1dent3
Copy link
Member

@Tom-Hudson Hello. Thank you. Tag v2.7.1.
The build has been launched. It will be ready in 15-20 minutes.
Please write here when you check it.

@rez1dent3 rez1dent3 added bug Something isn't working enhancement New feature or request labels Dec 4, 2024
@rez1dent3
Copy link
Member

Added to version 3.x as well.

@Tom-Hudson
Copy link
Author

@rez1dent3 I just tried the latest version and it has indeed fixed the issue! Thanks for the super fast response to this 🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants