Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[8.1.0] Add repository_ctx.original_name #25147

Closed
bazel-io opened this issue Jan 30, 2025 · 3 comments
Closed

[8.1.0] Add repository_ctx.original_name #25147

bazel-io opened this issue Jan 30, 2025 · 3 comments
Milestone
8.1.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #25121
@bazel-io bazel-io added this to the 8.1.0 release blockers milestone Jan 30, 2025
@bazel-io
Copy link
Member Author

bazel-io commented Feb 3, 2025

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java
src/test/py/bazel/bzlmod/mod_command_test.py

cc: @bazelbuild/triage

@iancha1992
Copy link
Member

@fmeum @Wyverald @meteorcloudy I don't think I can cherry-pick this. Could you please take a look?

@fmeum fmeum mentioned this issue Feb 4, 2025
Merged
@fmeum
Copy link
Collaborator

fmeum commented Feb 4, 2025

#25191

github-merge-queue bot pushed a commit that referenced this issue Feb 5, 2025
@fmeum
[8.1.0] Add repository_ctx.original_name (#25191)
b016ff3 
This new attribute contains the original value of the `name` attribute
at the instantiation site of the repo rule (e.g., `rctx.original_name`
would be `foo` if `rctx.name` is `+ext+foo`).

Fixes #24467

Closes #25121.

RELNOTES: Added `repository_ctx.original_name`, which contains the
original value of the `name` attribute as specified at the repo rule
call site.

PiperOrigin-RevId: 722731393
Change-Id: I2f7dada0c44b6bd4c0d2622fa1e97223382a8547 
(cherry picked from commit 8bcfb06)

Fixes #25147
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.0 release blockers
Development

No branches or pull requests
4 participants
@meteorcloudy @fmeum @bazel-io @iancha1992