Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

No changes in client after successful installation #35

Closed
Seikatsu-exe opened this issue Apr 22, 2019 · 1 comment
Closed

No changes in client after successful installation #35

Seikatsu-exe opened this issue Apr 22, 2019 · 1 comment
Labels
enhancement:implemented Enhancement that has been implemented enhancement:update Implementation that should be updated

Comments

@Seikatsu-exe
Copy link

Terminal output:
Selection_001

Discord:
Selection_002

Running Linux Mint 19.1, Canary build 36132, if that helps at all.
@ObserverOfTime
Copy link
Collaborator

ObserverOfTime commented Apr 22, 2019 •
edited
Loading

Use reinstall. Scratch that.
It seems that the new Canary update found another way to disable node integration.

Uncaught TypeError: window.require is not a function
    at cdn.staticaly.com/gh/rauenzi/BetterDiscordApp/d8b70a344605be4c3fc3fd2aa9a950111eab0ab0/js/main.min.js:1
    at cdn.staticaly.com/gh/rauenzi/BetterDiscordApp/d8b70a344605be4c3fc3fd2aa9a950111eab0ab0/js/main.min.js:1

Update: apparently electron made nodeIntegration: false the default in a recent commit (electron/electron@fade3eb) which means that we have to explicitly set it to true for BD to work.

@ObserverOfTime ObserverOfTime added the enhancement:update Implementation that should be updated label Apr 22, 2019
@ObserverOfTime ObserverOfTime added this to the next milestone Apr 22, 2019
@ObserverOfTime ObserverOfTime added help-wanted Extra attention is needed and removed help-wanted Extra attention is needed labels Apr 22, 2019
@ObserverOfTime ObserverOfTime removed this from the next milestone Apr 22, 2019
@ObserverOfTime ObserverOfTime added the enhancement:implemented Enhancement that has been implemented label May 8, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement:implemented Enhancement that has been implemented enhancement:update Implementation that should be updated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ObserverOfTime @Seikatsu-exe