Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

search broken when not in root dir of project #131

Closed
braineo opened this issue Jul 23, 2019 · 5 comments
Closed

search broken when not in root dir of project #131

braineo opened this issue Jul 23, 2019 · 5 comments

Comments

@braineo
Copy link

braineo commented Jul 23, 2019

Expected behavior

Can do helm-projectile-rg in any sub-directory in a project

Actual behavior

b62cea6 listed all project files to search, helm-rg will concatenate files with current working directory which results in path not found

Steps to reproduce the problem

open file in a sub folder of a project, do helm-projectile-rg and search anything

Backtraces if necessary (M-x toggle-debug-on-error)

Environment & version information

  • helm-projectile version:
  • helm version (in helm-pkg.el):
  • projectile version (M-x projectile-version):
  • Emacs version (M-x emacs-version):
  • OS:
@yeliu84
Copy link

yeliu84 commented Jul 24, 2019

I have the same issue. Now I need to set helm-rg-default-directory to 'git-root to workaround this issue.

@xiongtx
Copy link
Collaborator

xiongtx commented Jul 27, 2019

Sorry about that, I've reverted the commit.

@gayanhewa
Copy link

I get this triggered every time I run helm-projectile-rg

Error running timer: (error "Candidates function ‘helm-ag--do-ag-candidate-process’ should run a process") [3 times]

I also have :

(use-package helm-rg
  :config
  (setq helm-rg-default-directory 'git-root))

Am I doing anything wrong?

@willnevillain
Copy link

Error running timer: (error "Candidates function ‘helm-ag--do-ag-candidate-process’ should run a process") [3 times]

@gayanhewa that error appears to pertain to the helm-ag package, do you have any configuration related to that (or is maybe the keybinding bound to helm-ag instead)?

@gayanhewa
Copy link

Oh 🤦‍♂ , I will try to take a look. I managed to get helm-ag to work, for the time being, I will revert my changes and reset the key bindings to check this again. 🙇

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants