fix: always emit a message from emitError #565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #564
Description:
As described in the issue, #560 made a change that meant that all emitted events always included metadata as the last parameter, this meant that
message
was no longer the second parameter in error events which breaks some handling for users who where using that method to get the message details.Type of change:
Why is this change required?:
This ensures that the change is backwards compatible by making
emitError
emit undefined as the second parameter if messages were not provided to it.NOTE: This does changed the type from setting
void
in the return union for the error emitted to event to be more explicitlyundefined