Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Published JARs for versions 2.2.0 and 2.3.0 have an invalid module name in MANIFEST.MF #24

Closed
anderswisch opened this issue Nov 16, 2022 · 6 comments
Labels

Comments

@anderswisch
Copy link

Published JARs for versions 2.2.0 and 2.3.0 have an invalid module name in MANIFEST.MF.

Both contain this line:

Automatic-Module-Name: emailaddress-rfc2822

Because it contains a - character, it is not a valid identifier. Running jar --describe-module --file emailaddress-rfc2822-2.2.0.jar gives output:

Unable to derive module descriptor for: emailaddress-rfc2822-2.2.0.jar
Automatic-Module-Name: emailaddress-rfc2822: Invalid module name: 'emailaddress-rfc2822' is not a Java identifier
@anderswisch
Copy link
Author

I think this comes from https://github.com/bbottema/standard-project-parent/blob/master/pom.xml#L60 (artifactId can contain dashes)

@anderswisch
Copy link
Author

This problem also affects version 1.0.1 of https://github.com/bbottema/jetbrains-runtime-nullability-annotations

@bbottema
Copy link
Owner

Hmm, that's a problem. I'm not sure how to get the unique project name without dashes and I don't really have the time lately to do research. Any suggestions?

@anderswisch
Copy link
Author

I put up a clumsy fix for this in bbottema/standard-project-parent#10. Let me know what you think. It's been awhile since I tried to do this kind of thing in Maven.

@bbottema
Copy link
Owner

Fixed by aea17f8

@bbottema bbottema added the bug label Jan 13, 2023
@bbottema
Copy link
Owner

Fix released in 2.3.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants