Skip to content

fix: variableMap injection by using regex #127

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

katesclau
Copy link
Contributor

Fix for: #126

As replaceAll is not supported, we need to use RegExp to inject variableMap.

@katesclau katesclau changed the title Fix/variable map injection by using regex fix: variableMap injection by using regex Aug 28, 2021
@bboure
Copy link
Member

bboure commented Aug 30, 2021

Thanks for this @katesclau
Please fix the lint issue and it's ready to go 👍

@bboure bboure merged commit 63b9e85 into serverless-appsync:master Aug 30, 2021
bboure pushed a commit that referenced this pull request Aug 30, 2021
## [0.19.1](v0.19.0...v0.19.1) (2021-08-30)

### Bug Fixes

* variableMap injection by using regex ([#127](#127)) ([63b9e85](63b9e85))
@bboure
Copy link
Member

bboure commented Aug 30, 2021

🎉 This PR is included in version 0.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@katesclau katesclau deleted the fix/variable-map-injection-replace-all branch September 20, 2021 18:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants