diff --git a/package-lock.json b/package-lock.json index a50beb877..76b077d75 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-filings-ui", - "version": "7.4.7", + "version": "7.4.8", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-filings-ui", - "version": "7.4.7", + "version": "7.4.8", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/base-address": "2.0.9", diff --git a/package.json b/package.json index 7ad38bc23..b26682c51 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-filings-ui", - "version": "7.4.7", + "version": "7.4.8", "private": true, "appName": "Filings UI", "sbcName": "SBC Common Components", diff --git a/src/stores/businessStore.ts b/src/stores/businessStore.ts index e018dc7e8..9df0c7484 100644 --- a/src/stores/businessStore.ts +++ b/src/stores/businessStore.ts @@ -280,18 +280,13 @@ export const useBusinessStore = defineStore('business', { }, /** - * Is True for non-BEN corps if FF is disabled. - * Is False for BENs and other entity types. + * Is True for any business in the FF list, else False. * Used to apply special pre-go-live functionality. */ isDisableNonBenCorps (): boolean { - if ( - this.isEntityBcCompany || this.isEntityBcCcc || this.isEntityBcUlcCompany || - this.isEntityContinueIn || this.isEntityCccContinueIn || this.isEntityUlcContinueIn - ) { - return !GetFeatureFlag('enable-non-ben-corps') - } - return false + // initially, this was True for all non-BEN corps (when FF was off) + // now, this is True for the specified businesses only + return !!GetFeatureFlag('businesses-to-manage-in-colin')?.includes(this.getIdentifier) }, // diff --git a/src/utils/feature-flags.ts b/src/utils/feature-flags.ts index 2f8e55ed2..644cb7d87 100644 --- a/src/utils/feature-flags.ts +++ b/src/utils/feature-flags.ts @@ -9,9 +9,9 @@ declare const window: any */ const defaultFlagSet: LDFlagSet = { 'banner-text': '', // by default, there is no banner text + 'businesses-to-manage-in-colin': [], 'enable-digital-credentials': false, 'enable-legal-name-fix': false, - 'enable-non-ben-corps': false, 'sentry-enable': false, // by default, no sentry logs 'show-alert-phone-numbers-firm': false, 'supported-agm-extension-entities': [], diff --git a/tests/unit/CorporateOnline.spec.ts b/tests/unit/CorporateOnline.spec.ts index 3b3b29263..d47168fec 100644 --- a/tests/unit/CorporateOnline.spec.ts +++ b/tests/unit/CorporateOnline.spec.ts @@ -17,9 +17,11 @@ describe('Corporate Online alert', () => { beforeAll(() => { businessStore.$state.businessInfo.goodStanding = true businessStore.$state.businessInfo.legalType = CorpTypeCd.BC_COMPANY + businessStore.$state.businessInfo.identifier = 'BC1234567' + vi.spyOn(utils, 'GetFeatureFlag').mockImplementation(flag => { - if (flag === 'enable-non-ben-corps') return false - return null + if (flag === 'businesses-to-manage-in-colin') return ['BC1234567'] + return [] }) })