Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vue3 upgrade: v-sanitize #16490

Closed
5 tasks
severinbeauvais opened this issue May 23, 2023 · 6 comments
Closed
5 tasks

Vue3 upgrade: v-sanitize #16490

severinbeauvais opened this issue May 23, 2023 · 6 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented May 23, 2023

This will need to be replaced for Vue3. See solution in comments below.

  • fork repo into bcgov space so we don't depend on an external private package no longer needed
  • update Business Edit UI
  • update Business Create UI if needed
  • update Business Edit UI if needed
  • check BCRS Shared Components
@seeker25
Copy link
Collaborator

https://leopiccionia.github.io/vue-sanitize-directive/ <-- works for Vue 3, we use it in auth-web

@severinbeauvais
Copy link
Collaborator Author

Nice - it works in Vue2 as well, so we can change it over before flipping the big switch.

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Sep 19, 2023

As this is a user's repo (not npm), I recommend that we use a local fork of it (as we do with vue-test-utils-helpers).

No longer needed as this package is in npm.

@seeker25
Copy link
Collaborator

@severinbeauvais
Copy link
Collaborator Author

BLOCKED as the new package doesn't seem to work, and the existing package doesn't seem to work, so I can test/verify that my changes are good.

@severinbeauvais
Copy link
Collaborator Author

Travis agreed that this could be merged in.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants