Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Legal API - Fix List of Outputs #18370

Closed
5 tasks done
severinbeauvais opened this issue Oct 27, 2023 · 5 comments
Closed
5 tasks done

Legal API - Fix List of Outputs #18370

severinbeauvais opened this issue Oct 27, 2023 · 5 comments
Assignees
Labels
ENTITY Business Team

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 27, 2023

  • Verify that back end list of outputs contains output letter + receipt
  • Change code to show proper title for letter (should be: "Letter of ...")
  • Change code to return letter PDF
  • Receipt is already automatically populated
  • Change filing display name to "Request for AGM Extension"
@leodube-aot
Copy link
Collaborator

leodube-aot commented Nov 7, 2023

Waiting on #18053 before this is ready for QA.

@severinbeauvais
Copy link
Collaborator Author

Can you show some Postman responses in the meantime?

@leodube-aot
Copy link
Collaborator

@severinbeauvais We need the filing to at least be in PAID status, i.e. has passed validation and has been PAID for. In the meantime the unit tests provide a look at what the outputs look like.

Private Zenhub Image

@severinbeauvais
Copy link
Collaborator Author

Excellent! Thanks for the screenshot.

@severinbeauvais
Copy link
Collaborator Author

I am not sure how this ticket was tested, because I think we cannot yet file AGM extensions, ergo we cannot see the outputs yet.

However, assuming the same fix was applied to AGM Location Change, then that looks OK:

image

(Note that UI/UX team had requested that the filing title be changed from "Request for AGM ..." to simply "AGM ...", which is what we currently have.)

This was referenced Dec 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

3 participants