Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create UI: implement 3 options for Business Name/Type #18788

Closed
13 of 14 tasks
severinbeauvais opened this issue Nov 28, 2023 · 6 comments
Closed
13 of 14 tasks

Create UI: implement 3 options for Business Name/Type #18788

severinbeauvais opened this issue Nov 28, 2023 · 6 comments
Assignees
Labels

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Nov 28, 2023

https://preview.uxpin.com/7f4cfe5fe4b0ba15a83d518177efe82a08e99167#/pages/164828179/simulate/sitemap

Scenario 1: numbered amalgamation -> show numbered panel only (no Undo button). already done in #18538
Scenario 2: named amalgamtion -> show NR panel only (no Undo button). already done in #18538
Scenario 3: regular amalgamation starting from existing business (neither numbered nor named). THIS TICKET

  1. Create panel with radio buttons to select existing amalgamating business Name.
  2. Reuse panels to select options and the panel to select option 2 and to use an NR.
  3. Add undo buttons to options.
  4. Save/restore selected option.
  • Store a variable for the UI's purpose. Initially is empty. Selection will be made - 1 of 3.
  • basic component with 3 options
  • yellow box for option 1 if no businesses have been added to the table
  • radio box for selecting one of the businesses in the table (named or numbered only)
  • prompt and display (including name translations) for option 2
  • new checkbox for option 3
  • resulting business name for option 2
  • name translations
  • undo, validations
  • fix/add unit tests will be done in Create UI: implement new Amalgamating Businesses component - Part IV - DO THIS LAST #18641

Also:

  • changed snackbar close button to an icon
  • reset business lookup state each time it's used
  • added validation for historical TING

Validations:

  • NR type must match type of business selected for NOA (if one was selected)
@severinbeauvais
Copy link
Collaborator Author

Some questions are outstanding... waiting for future designs.

@jdyck-fw
Copy link
Collaborator

Some of the details here may not be 100% correct, rely on the designs as the source of truth.

@severinbeauvais
Copy link
Collaborator Author

Hi @janisrogers . Can you look at this, please?

@janisrogers
Copy link
Collaborator

janisrogers commented Jan 3, 2024

This comment was moved to new ticket, #19136.

@severinbeauvais
Copy link
Collaborator Author

As discussed, moving this to RFQA.

@PCC199 PCC199 closed this as completed Jan 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants