Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Name-Examination Vue 3: error occurs when 'Approve' a name #20593

Closed
eve-git opened this issue Apr 3, 2024 · 4 comments
Closed

Name-Examination Vue 3: error occurs when 'Approve' a name #20593

eve-git opened this issue Apr 3, 2024 · 4 comments
Assignees
Labels
bug Something isn't working Names Team Name Request Name Examination Team Priority1

Comments

@eve-git
Copy link
Collaborator

eve-git commented Apr 3, 2024

When Approve/Quick Approve a name, an error occurred in Developers tools console, although, everything works fine after it.
image.png

image.png

@eve-git eve-git added bug Something isn't working Names Team Name Request Name Examination Team labels Apr 3, 2024
@eve-git eve-git changed the title Name-Examination bug: error occurs when 'Approve' a name Name-Examination Vue3 bug: error occurs when 'Approve' a name Apr 4, 2024
@eve-git eve-git changed the title Name-Examination Vue3 bug: error occurs when 'Approve' a name Name-Examination Vue 3: error occurs when 'Approve' a name Apr 4, 2024
@eve-git
Copy link
Collaborator Author

eve-git commented Apr 12, 2024

After approved, the name-examination needs to be reload. However, the currentNameChoice is not set when nrStatus = 'APPROVED'
https://github.com/bcgov/name-examination/blob/main/store/examine/index.ts#L491
so that after pushDecision, currentNameObj = undefined and the error occurred
https://github.com/bcgov/name-examination/blob/main/store/examine/index.ts#L654

@eve-git
Copy link
Collaborator Author

eve-git commented Apr 17, 2024

test:
open Developers Tools and watch on console when approving a name. No error should be shown in console.

@eve-git
Copy link
Collaborator Author

eve-git commented Apr 17, 2024

deployed in both TEST and DEV environment. Ready for testing

@oanyahuru
Copy link
Collaborator

oanyahuru commented Apr 18, 2024

@eve-git I tested. I didnt get that error. I however got another one that might need to be investigated.

image.png

Moving this along since another bug (20917) ticket has been created

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working Names Team Name Request Name Examination Team Priority1
Projects
None yet
Development

No branches or pull requests

3 participants