-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Name Request - Check if Session Storage is enabled in the browser before loading #9694
Comments
I believe Namerequest UI -- and in fact all BCROS web apps -- cannot function correctly without session storage available. Maybe we should have a banner or warning dialog (sim. to IE11) for this. |
The issue is not only old browsers. The user can also disable it. |
Well, I tried to disable total support to Session Storage in Chrome and FF and the application doesn't load. But still I think we could check if the browser supports read and write before continuing. |
This issue is not really a problem for Namerequest UI, since this app will not load if Session Storage is not available (so users will not get into trouble / no corrupt data). However, it would nice to alert users (as we do for IE11) at the top level of BCROS web pages, that they "cannot continue if Session Storage is not available" (since it is used extensively for config keys, etc). (Or perhaps, this can be tested, and if BCROS doesn't load at all then it's a lesser issue. But it might still be nice to display an alert or something.) |
We have a ticket #9429 to handle IE11 issue. So, I think we can close this issue. |
IE11 and whether session storage is enabled are different things: a user can be running the latest Chrome browser and still turn off session storage. |
i will close this old ticket. if IE11 issues are reported we can create a new ticket with new information on it. most users would be using edge |
There is no check if the session storage is available in the user's browser in Name Request UI and all the auth for external users is done through the session storage. That can cause errors when the user pay for a NR.
Reference:
https://stackoverflow.com/a/6600933/16940959
https://stackoverflow.com/a/25050910/16940959
https://stackoverflow.com/questions/7192405/most-elegant-way-to-check-sessionstorage-support/12337672
The text was updated successfully, but these errors were encountered: