Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

For plant community action (anywhere else this dropdown type is used?) the drop down behaviour is confusing. #525

Closed
LisaMoore1 opened this issue Jan 28, 2020 · 6 comments
Assignees
Labels
Bug Something isn't working/a problem that needs to be fixed ready to test
Milestone

Comments

@LisaMoore1
Copy link
Collaborator

LisaMoore1 commented Jan 28, 2020

If you select "Other" you MUST type something or you get a "could not save due to invalid fields error" but it looks like leaving it just as "other" should be OK

  • add some sort of messaging that you must enter text and if blank you get an error message under the field

When you type something in for "other" (ex. "thing") then when you look at the dropdown it now shows what you typed at the bottom of the list. It is unclear that if you want to change what you entered for "other" you need to select your text (ex. "thing") and then type over it in the field

  • add clarity here by perhaps leaving it saying "other" in the drop down and then provide the same messaging/error that you use for the first part of this (or however else it is solved)

Solution for the two parts probably all part of one solution.

For this (and all dropdowns) it is confusing to have anything appear in the field before a selection is made. If you've activated the dropdown the field should remain blank until you pick something otherwise it looks like you've made a selection and you actually haven't.

@LisaMoore1 LisaMoore1 added the Bug Something isn't working/a problem that needs to be fixed label Jan 28, 2020
@LisaMoore1 LisaMoore1 added this to the Sprint 8.0 milestone Jan 29, 2020
@calebissharp calebissharp self-assigned this Jan 31, 2020
@calebissharp
Copy link
Contributor

@LisaMoore1

For this (and all dropdowns) it is confusing to have anything appear in the field before a selection is made. If you've activated the dropdown the field should remain blank until you pick something otherwise it looks like you've made a selection and you actually haven't.

This has been discussed previously in #164 (comment) and is caused by an upstream bug in semantic-ui.

The other parts of the issue I can fix by making the plant community action dropdown behaviour more like the indicator plant dropdown.

@LisaMoore1
Copy link
Collaborator Author

@calebissharp Forgot we'd already been there done that on that particular item. In that case can you make "Select" the first entry on the list so that that is what shows until you've made a selection?

@calebissharp
Copy link
Contributor

@LisaMoore1 I'm not sure that would be possible. How important is this?

@LisaMoore1
Copy link
Collaborator Author

@calebissharp two calls in the last week where, when watching screen share, they've thought they'd selected something because the text they wanted was displayed but they hadn't. How big would it be?

See https://tools.usps.com/zip-code-lookup.htm?byaddress the state dropdown for an example.

@calebissharp
Copy link
Contributor

@LisaMoore1 We'd have to replace the dropdowns with a component from another library. It won't look the same, but hopefully would have better behaviour. I'd put the estimate at 2.

@LisaMoore1
Copy link
Collaborator Author

@calebissharp Can you move that element to a separate issue and put it in backlog. Fixing it so that it isn't opening below the working window and some sort of instruction re. how to deal with "other" are the primary wins for this one.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working/a problem that needs to be fixed ready to test
Projects
None yet
Development

No branches or pull requests

2 participants