Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BIP 84 Private Key Throws Misleading Error Message #1019

Open
JoePotentier opened this issue May 25, 2021 · 1 comment
Open

BIP 84 Private Key Throws Misleading Error Message #1019

JoePotentier opened this issue May 25, 2021 · 1 comment

Comments

@JoePotentier
Copy link

While testing the ability to import the private key generated by Electrum Wallet on testnet I found that electrum was providing an vprv key based on the BIP 84 standard.

While passing this key in walletClient.createWallet() as the "master" key it throws the following error:

Error: Network mismatch for xprivkey.

At a minimum, this error is misleading. The vprv key is used for testnet P2WPKH addresses. While I can't expect bcoin to support every BIP standard, the error message should not mention that the network is incorrect if it does not recognize the private key format.

@pinheadmz
Copy link
Member

BIP84 is not supported by bcoin there is an open PR to add this feature: #616

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants