Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Error in SMTP class // scripts aborts, no error handling possible #1278

Open
iFlash opened this issue Jan 25, 2024 · 1 comment
Open

Error in SMTP class // scripts aborts, no error handling possible #1278

iFlash opened this issue Jan 25, 2024 · 1 comment

Comments

@iFlash
Copy link

iFlash commented Jan 25, 2024

In line 202 of the SMTP class, we find this construct:

			if (!$socket) {
				$fw->error(500,$errstr);
				return FALSE;
			}

This seems to be wrong: If the socket can not be established, the script aborts with an error 500, and the return false; never gets executed; thus, no further error handling is possible.

The line throwing the error has to be removed IMHO.

@ikkez
Copy link
Collaborator

ikkez commented Jan 30, 2024

Not quite right.. if you set the system variable HALT = FALSE the error handler wont abort further code execution. Also a custom error handler might handle it differently.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants