Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PaneItemExpander deeper nesting #1019

Open
ignatz opened this issue Jan 31, 2024 · 1 comment
Open

PaneItemExpander deeper nesting #1019

ignatz opened this issue Jan 31, 2024 · 1 comment
Labels
enhancement New feature or request w: NavigationView Related to the NavigationView widget

Comments

@ignatz
Copy link

ignatz commented Jan 31, 2024

I'd like to nest pane items more deeply than 1 level. The implementation clearly asserts: "There can not be nested PaneItemExpanders" while MS' documentation reads: "Although NavigationViewItem can contain any number of nested levels, we recommend keeping your app's navigation hierarchy shallow. We believe two levels is ideal for usability and comprehension." (https://learn.microsoft.com/en-us/windows/apps/design/controls/navigationview#hierarchical-navigation).

Describe the solution you'd like
I'm mostly wondering if the limiting is intentional, if there's a technical reason, or if you'd be willing to accept a patch.

@bdlukaa
Copy link
Owner

bdlukaa commented Jan 31, 2024

Because of the way we traverse the pane items and calculate the index, nesting pane items is not allowed.

A patch would be appreciated, but I recommend you to read #919 first!

@bdlukaa bdlukaa added the enhancement New feature or request label Feb 6, 2024
@bdlukaa bdlukaa added the w: NavigationView Related to the NavigationView widget label Jan 31, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request w: NavigationView Related to the NavigationView widget
Projects
None yet
Development

No branches or pull requests

2 participants