Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🐛 Wrong disabled color for FilledButton #207

Closed
tobiasht opened this issue Mar 1, 2022 · 7 comments · Fixed by #209
Closed

🐛 Wrong disabled color for FilledButton #207

tobiasht opened this issue Mar 1, 2022 · 7 comments · Fixed by #209
Assignees
Labels
bug Something isn't working

Comments

@tobiasht
Copy link
Contributor

tobiasht commented Mar 1, 2022

Describe the bug
When a FilledButton is disabled. It looks identical to a Button which is active. It makes it hard for the user to know that they cannot press the button.

image

I guess the correct color would be the colors used here:
https://developer.microsoft.com/en-us/fluentui#/controls/web/button

image

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 1, 2022

Can you post a reproducible code sample?

@tobiasht
Copy link
Contributor Author

tobiasht commented Mar 1, 2022

Column(
      children: [
        FilledButton(child: Text("FilledButton"), onPressed: null),
        Button(child: Text("Button"), onPressed: () {}),
      ],
    );

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 1, 2022

Weird. FilledButton should be colored

@tobiasht
Copy link
Contributor Author

tobiasht commented Mar 3, 2022

The FilledButton is only filled when it has an action. The problem is that it looks identical to a Button when it is disabled/no action

@tobiasht
Copy link
Contributor Author

tobiasht commented Mar 3, 2022

There is no hover color either, for FilledButton.

@WinXaito
Copy link
Collaborator

WinXaito commented Mar 3, 2022

Confirmed on latest version:

Button and FilledButton disabled

image

Button and FilledButton enabled

image

@WinXaito WinXaito added the bug Something isn't working label Mar 3, 2022
@WinXaito WinXaito self-assigned this Mar 3, 2022
@WinXaito
Copy link
Collaborator

WinXaito commented Mar 3, 2022

I will send a PR now

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants