Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ability to change the NavigationPaneItem height #762

Closed
ricardoboss opened this issue Mar 9, 2023 · 2 comments
Closed

Add ability to change the NavigationPaneItem height #762

ricardoboss opened this issue Mar 9, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ricardoboss
Copy link

ricardoboss commented Mar 9, 2023

Is your feature request related to a problem? Please describe.
I think the icons of the NavigationPane are a bit small and want to change their size. I can change the width of the column, the icon size itself, but not the pane height.

Describe the solution you'd like
Currently, the pane height is hardcoded (see https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/controls/navigation/navigation_view/pane_items.dart#L204).

Describe alternatives you've considered
As described above, changed column width and icon size, neither of which let me change the height.

Additional context
I asked in Discord and was told to file an issue for this.

@bdlukaa bdlukaa added help wanted Extra attention is needed enhancement New feature or request and removed help wanted Extra attention is needed labels Mar 9, 2023
@bdlukaa
Copy link
Owner

bdlukaa commented Mar 9, 2023

The hardcoded value is actually wrong. The value should be 40, as per https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/NavigationView/NavigationView_rs1_themeresources_v1.xaml#L248

A fixed height shouldn't be provided as well. Instead, just a min height, making the widget possible to expand as it needs.

NavigationView in general doesn't follow the theme resources from Microsoft and should be updated

@ricardoboss
Copy link
Author

ricardoboss commented Mar 13, 2023

Hi, any updates on this? Can I help in any way?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants