feat: cleanup exceptions to avoid duplication (#153)

Author: bdraco

yalexs/api_async.py

@@ -41,7 +41,7 @@
 )
 from .const import DEFAULT_BRAND
 from .doorbell import Doorbell, DoorbellDetail
-from .exceptions import AugustApiAIOHTTPError
+from .exceptions import AugustApiAIOHTTPError, YaleApiError, InvalidAuth
 from .lock import (
     Lock,
     LockDetail,
@@ -460,24 +460,24 @@ def _raise_response_exceptions(response: ClientResponse) -> None:
         response.raise_for_status()
     except ClientResponseError as err:
         if err.status in (HTTPStatus.UNAUTHORIZED, HTTPStatus.FORBIDDEN):
-            raise AugustApiAIOHTTPError(
+            raise InvalidAuth(
                 f"Authentication failed: Verify brand is correct: {err.message}", err
             ) from err
         if err.status == 422:
-            raise AugustApiAIOHTTPError(
+            raise YaleApiError(
                 f"The operation failed because the bridge (connect) is offline: {err.message}",
                 err,
             ) from err
         if err.status == 423:
-            raise AugustApiAIOHTTPError(
+            raise YaleApiError(
                 f"The operation failed because the bridge (connect) is in use: {err.message}",
                 err,
             ) from err
         if err.status == 408:
-            raise AugustApiAIOHTTPError(
+            raise YaleApiError(
                 f"The operation timed out because the bridge (connect) failed to respond: {err.message}",
                 err,
             ) from err
-        raise AugustApiAIOHTTPError(
+        raise YaleApiError(
             f"The operation failed with error code {err.status}: {err.message}.", err
         ) from err

yalexs/exceptions.py

@@ -3,7 +3,6 @@
 from http import HTTPStatus
 
 from aiohttp import ClientError, ClientResponseError
-from requests.exceptions import HTTPError
 
 
 class AugustApiAIOHTTPError(Exception):
@@ -22,9 +21,25 @@ def __init__(self, message: str, aiohttp_client_error: ClientError) -> None:
         )
 
 
-class AugustApiHTTPError(HTTPError):
+class YaleApiError(AugustApiAIOHTTPError):
     """An yale access api error with a friendly user consumable string."""
 
 
+class RequireValidation(Exception):
+    """Error to indicate we require validation (2fa)."""
+
+
+class CannotConnect(YaleApiError):
+    """Error to indicate we cannot connect."""
+
+
+class InvalidAuth(YaleApiError):
+    """Error to indicate there is invalid auth."""
+
+
+class YaleXSError(Exception):
+    """Base error."""
+
+
 class ContentTokenExpired(Exception):
     """Token required for accessing this resource is not valid."""

yalexs/manager/exceptions.py

@@ -2,18 +2,10 @@
 
 from __future__ import annotations
 
-
-class RequireValidation(Exception):
-    """Error to indicate we require validation (2fa)."""
-
-
-class CannotConnect(Exception):
-    """Error to indicate we cannot connect."""
-
-
-class InvalidAuth(Exception):
-    """Error to indicate there is invalid auth."""
-
-
-class YaleXSError(Exception):
-    """Base error."""
+from ..exceptions import (  # noqa: F401
+    YaleApiError,
+    RequireValidation,
+    CannotConnect,
+    InvalidAuth,
+    YaleXSError,
+)