Merge pull request #214 from gVirtu/improvement/slack_webhook_regex

Update Slack Webhook regex with tests

Author: bee-san

fixtures/file

@@ -95,4 +95,6 @@ b2ced6f5-2542-4f7d-b131-e3ada95d8b75
 
 otpauth://totp/Example:alice@google.com?secret=JBSWY3DPEHPK3PXP&issuer=Example
 
-sshpass -p MyPassw0RD! ssh root@10.0.0.10
+sshpass -p MyPassw0RD! ssh root@10.0.0.10
+
+https://hooks.slack.com/services/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

pywhat/Data/regex.json

@@ -258,7 +258,7 @@
    },
    {
       "Name": "Slack Webhook",
-      "Regex": "(?i)^(https://hooks.slack.com/services/T[a-zA-Z0-9_]{8}/B[a-zA-Z0-9_]{8}/[a-zA-Z0-9_]{24})$",
+      "Regex": "(?i)^(https://hooks.slack.com/services/T[a-zA-Z0-9_]{8,10}/B[a-zA-Z0-9_]{8,10}/[a-zA-Z0-9_]{24})$",
       "plural_name": false,
       "Description": null,
       "Exploit": "If the command below returns 'missing_text_or_fallback_or_attachments', it means\nthat the URL is valid, any other responses would mean that the URL is invalid.\n  $ curl -s -X POST -H \"Content-type: application/json\" -d '{\"text\":\"\"}' \"SLACK_WEBOOK_URL_HERE\"\n",
@@ -269,7 +269,14 @@
          "API Keys",
          "Credentials",
          "Slack"
-      ]
+      ],
+      "Examples": {
+         "Valid": [
+            "https://hooks.slack.com/services/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",
+            "https://hooks.slack.com/services/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"
+         ],
+         "Invalid": []
+      }
    },
    {
       "Name": "Amazon Web Services Simple Storage (AWS S3) URL",
@@ -2587,4 +2594,4 @@
          "Invalid": []
       }
    }
-]
+]

tests/test_click.py

@@ -639,6 +639,13 @@ def test_file_fixture_sshpass():
     assert re.findall("SSHPass Clear Password Argument", str(result.output))
 
 
+def test_file_fixture_slack_webhook():
+    runner = CliRunner()
+    result = runner.invoke(main, ["fixtures/file"])
+    assert result.exit_code == 0
+    assert re.findall("Slack Webhook", str(result.output))
+
+
 def test_format():
     runner = CliRunner()
     result = runner.invoke(