Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LibModel.add sends database_change twice #5560

Open
valrus opened this issue Dec 26, 2024 · 0 comments · May be fixed by #5561
Open

LibModel.add sends database_change twice #5560

valrus opened this issue Dec 26, 2024 · 0 comments · May be fixed by #5561

Comments

@valrus
Copy link
Contributor

valrus commented Dec 26, 2024

Problem

Calling Library.add causes the database_change event to be sent twice, not once. This branch adds a minimal test (test/test_database_change.py) which demonstrates the problem: it fails without the fix in beets/library.py.

I will open a PR with that branch (which includes an unrelated fix and a potential improvement) shortly.

Setup

  • OS: macOS
  • Python version: 3.12.4
  • beets version: 2.2.0
  • Turning off plugins made problem go away (yes/no): no

My configuration is probably irrelevant here, but I can provide it if needed.

@valrus valrus linked a pull request Dec 26, 2024 that will close this issue
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant